-
Notifications
You must be signed in to change notification settings - Fork 152
Refactoring eip-4844 #2752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactoring eip-4844 #2752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palinatolmach
approved these changes
May 6, 2025
Robertorosmaninho
approved these changes
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, I've accidently closed the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-4844 Blob Validation Implementation
This PR implements missing blob gas validation for EIP-4844 and adds some checks for transaction and block validity:
Transaction Validation
#isValidTransaction
to check transaction validity before starting to execute it, included missing checks as defined in ethereum/execution-specs#deductBlobGas
operation#checkTxVersionedHashes
Block Validation
#validateBlockBlobs
to verify total blob count and excess blob gas#finalizeBlockBlobs
for block-level validationpreviousExcessBlobGas
andpreviousBlobGasUsed
cellsGas Calculations
evm.md
togas.md
:Ctotalblob
- calculates gas used per blobCbasefeeperblob
- computes blob base feeCblobfee
- calculates total blob feeCexcessblob
- maintains excess blob gas between blocksError Handling
EVMC_INVALID_BLOCK
status code for blob validation failuresThis implementation ensures that KEVM correctly rejects blocks with invalid blob gas parameters, matching Ethereum consensus rules.
The EIP-7691 from Pectra will update the values of the schedule vars added here.